Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix any abi fail #145

Merged
merged 6 commits into from
Aug 22, 2024
Merged

fix any abi fail #145

merged 6 commits into from
Aug 22, 2024

Conversation

technophile-04
Copy link
Member

Description

  • Added a timeout for anyabi so that it fixes current issue
  • used useQuery for fetching data so that we cache request and don't make same request when going from home page => contract address page

@vercel Vercel
Copy link

vercel bot commented Aug 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abi-ninja-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 1:31pm

@technophile-04
Copy link
Member Author

Ohh I think I know why some of the test are failing, will update it soon

@technophile-04
Copy link
Member Author

Seem like Parex chain is rpc down that's why the last test seems to fail :/

image

https://chainlist.org/chain/322202

Will update that test to consider different chain

portdeveloper
portdeveloper approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@portdeveloper portdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran the tests locally and everything works great!

amazing work as always!

technophile-04
technophile-04 commented Aug 22, 2024
View reviewed changes
Copy link
Member Author

@technophile-04 technophile-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @portdeveloper! Merging this

@technophile-04 technophile-04 merged commit cb79dc1 into main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portdeveloper portdeveloper portdeveloper approved these changes

@Pabl0cks Pabl0cks Awaiting requested review from Pabl0cks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@technophile-04 @portdeveloper